Set default layout.axis.tickmode to 'sync' when axis is overlaying
#7684
+32
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilykl
force-pushed
the
shared-axis-lines-default
branch
from
e7ee5b3 to
2be45e2
Compare
emilykl
force-pushed
the
shared-axis-lines-default
branch
from
cb1bf35 to
c4c70fd
Compare
emilykl
force-pushed
the
shared-axis-lines-default
branch
from
7230cfb to
7d71516
Compare
camdecoster
approved these changes
Jan 23, 2026
Contributor
camdecoster
left a comment
camdecoster
left a comment
There was a problem hiding this comment.
Looks good! I left a few small syntax suggestions, but it's good to go as is.
| var axListIType = axListI[axisType]; | ||
| if(!axListI.fixedrange && axListIType.tickmode === 'sync') activeAxIds.push(axListIType._id); | ||
| var axId = axListIType._id; | ||
| if(!axListI.fixedrange && axListIType.tickmode === 'sync' && activeAxIds.indexOf(axId) === -1) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if(!axListI.fixedrange && axListIType.tickmode === 'sync' && activeAxIds.indexOf(axId) === -1) { | |
| if(!axListI.fixedrange && axListIType.tickmode === 'sync' && !activeAxIds.includes(axId)) { |
| 'If *sync*, the number of ticks will sync with the overlayed axis', | ||
| 'set by `overlaying` property.' | ||
| 'set by `overlaying` property. When no other tick info is provided,', | ||
| 'overlyaing (non-categorical) axes default to *sync*, while other axes default to *auto*.', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'overlyaing (non-categorical) axes default to *sync*, while other axes default to *auto*.', | |
| 'overlaying (non-categorical) axes default to *sync*, while other axes default to *auto*.', |
| var isTypedArraySpec = require('../../lib/array').isTypedArraySpec; | ||
| var decodeTypedArraySpec = require('../../lib/array').decodeTypedArraySpec; | ||
|
|
||
| module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType, opts) { |
Contributor
There was a problem hiding this comment.
Suggested change
| module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType, opts) { | |
| module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType, opts = {}) { |
|
|
||
| module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType, opts) { | ||
| if(!opts) opts = {}; | ||
| if (!opts) opts = {}; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!opts) opts = {}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7683
This PR slightly modifies the default
tickmodelogic, such thattickmodedefaults to'sync'rather than'auto'for overlaying axes. Motivation is explained in the linked issue.Note: One case is excluded: When the overlaying axis is categorical (or multicategory), tickmode continues to default to
'auto'rather than'sync', as'sync'causes unexpected behavior with categorical axes and is probably never intended by the user.